-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept lowercase Z (1z..) for UPS tracking numbers #102
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes involve updating the regex pattern in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- couriers/ups.json (2 hunks)
Additional comments not posted (2)
couriers/ups.json (2)
9-9
: Approve the regex pattern change.The updated regex pattern ensures that both uppercase 'Z' and lowercase 'z' are accepted in UPS tracking numbers, which aligns with the PR objective.
131-131
: Approve the addition of the new valid tracking number example.The new valid tracking number example containing a lowercase 'z' provides a test case for the updated regex pattern, ensuring the pattern works as intended.
I realize UPS probably always treats the Z as uppercase, however I'm dealing with some messy data where it's sometimes lowercase, so I'm curious if this is something that should be solved at the library level, or in the application.
Summary by CodeRabbit